Adding Scale Out functionality #613
Conversation
radez
commented
Feb 20, 2025
radez
commented
- Add nodes to worker inventory section and update vars in scaleout.yml to add nodes to the existing cluster.
- https://docs.openshift.com/container-platform/4.17/nodes/nodes/nodes-nodes-adding-node-iso.html
- Add nodes to worker inventory section and update vars in scaleout.yml to add nodes to the existing cluster. - https://docs.openshift.com/container-platform/4.17/nodes/nodes/nodes-nodes-adding-node-iso.html
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: radez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@josecastillolema: The following commands are available to trigger required jobs: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test deploy-sno |
|
/test deploy-5nodes |
The test failed because of: Let me take care of this tomorrow morning, we need to update the secrets. |
Ok I was going to look into the route issue more this afternoon also. |
Should be fixed when openshift/release#62015 merges |
|
/test deploy-5nodes |
There was a problem hiding this comment.
I'm wondering if we could include some sort of "limit" on initial deployment of a cluster such that say someone had a 200 node allocation given to them, and they ran create inventory, they would have 196 workers in the worker section. I am thinking we could make mno-deploy only deploy say 120 of the worker nodes and you'd have to use the mno-scale-out.yml playbook to increase the count of workers above this initial threshold. Do you think it is worth it to implement that into mno-deploy?
| @@ -4,29 +4,29 @@ | |||
| - name: Boot iso on dell hardware | |||
| include_tasks: dell.yml | |||
| with_items: | |||
| - "{{ groups[inventory_group][:index|int] }}" | |||
| - "{{ groups[inventory_group][offset:index|int] }}" | |||
There was a problem hiding this comment.
Does offset need the cast to an int here (Line 7, 13, 19, and 25) like line 31 has?
| hosts: bastion | ||
| vars_files: | ||
| - vars/scale_out.yml | ||
| - vars/all.yml |
There was a problem hiding this comment.
Is the all.yml needed for scaling up the cluster?
| - name: Approve pending CSRs | ||
| shell: | | ||
| KUBECONFIG={{ bastion_cluster_config_dir }}/kubeconfig oc adm certificate approve {{ item.metadata.name }} | ||
| with_items: "{{ oc_get_csr.stdout | from_json | json_query(qry) }}" |
There was a problem hiding this comment.
I know we still have a lot of with_items throughout the playbooks and roles, but I think we should strive for new tasks to use loop instead.
|
/test deploy-5nodes |
|
@radez: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This needs to be rebased to pick up the fix in #619 for CI to work |
